[Webkit-unassigned] [Bug 44096] Geolocation clearWatch() needs to protect against invalid IDs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44096


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #3 from Darin Adler <darin at apple.com>  2010-08-17 14:09:58 PST ---
(In reply to comment #2)
> Maybe the problem should be fixed within HashMap (or whatever's causing it)?

Changing HashMap itself directly is probably out of the question. HashMap achieves its speed in part by reserving values. We could use a hash table with a different design, but we’ve repeatedly reaffirmed our desire to use this.

Putting the fix closer to the use of the HashMap object would make sense for some call sites like these. We could add some new functions to HashMap called safeFind and safeGet that would work more slowly and check for the empty and deleted values, for uses in sites like these where we need the reliable but slower behavior. That might be a cleaner fix than the higher level validity checks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.