[Webkit-unassigned] [Bug 43814] selectionStart clobbered if textarea isn't focused
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 17 13:32:09 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=43814
Tony Chang <tony at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64619|review? |review+
Flag| |
--- Comment #3 from Tony Chang <tony at chromium.org> 2010-08-17 13:32:10 PST ---
(From update of attachment 64619)
> diff --git a/LayoutTests/fast/forms/text-control-select-blurred.html b/LayoutTests/fast/forms/text-control-select-blurred.html
Nit: Can you add some text explaining what this is testing?
> diff --git a/WebCore/rendering/RenderTextControl.cpp b/WebCore/rendering/RenderTextControl.cpp
> void RenderTextControl::setSelectionStart(int start)
> {
> - setSelectionRange(start, max(start, selectionEnd()));
> + HTMLTextFormControlElement* element = static_cast<HTMLTextFormControlElement*> (node());
Nit: kill the space between > and (? I don't see any other static_casts with this space.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list