[Webkit-unassigned] [Bug 37859] DumpRenderTree should save a stack trace and/or dump file when it crashes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 13:22:50 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37859


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64618|review?                     |review+
               Flag|                            |




--- Comment #7 from Sam Weinig <sam at webkit.org>  2010-08-17 13:22:50 PST ---
(From update of attachment 64618)
> diff --git a/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp b/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
> index b2aa836dc4ca126c4e3287d52161fc7423c744a6..24019390b32dfca7f3a532690f3fee164e4c144a 100644
> --- a/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
> +++ b/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
> @@ -111,6 +111,7 @@ void InjectedBundle::didReceiveMessage(WKStringRef messageName, WKTypeRef messag
>          WKRetainPtr<WKStringRef> ackMessageBody(AdoptWK, WKStringCreateWithCFString(CFSTR("BeginTest")));
>          WKBundlePostMessage(m_bundle, ackMessageName.get(), ackMessageBody.get());
>  
> +        CRASH();

This seems like a bad idea.

Otherwise, r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list