[Webkit-unassigned] [Bug 43948] Bugzilla "review" action should not paste full diff as comment by default

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 12:11:07 PDT 2010


--- Comment #7 from Darin Adler <darin at apple.com>  2010-08-17 12:11:06 PST ---
I edit the full diff too. Before we added the button to add individual diffs, this error was rare, and the script I wrote to remove the full diff if you don’t edit it, made it almost never happen.

The change here was adding that new workflow.

Currently, that gets in my way when I want to search for things within the patch. I click to select a word and copy it to search, and a text field gets inserted into the patch. This is inconvenient.

I don’t think the new feature for adding comments with individual lines to the patch review has a good UI yet. It confuses people and results in patches with full diffs. Please don’t fix this by removing the old workflow!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list