[Webkit-unassigned] [Bug 44092] Web Inspector: Add XMLHttpRequest Logging Tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44092





--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org>  2010-08-17 09:41:48 PST ---
> LayoutTests/http/tests/inspector/console-xhr-logging.html:11
>  +          console.log(result);
> We use convenience output() method for dumping stuff into the page.
> It then gets into the results via the dump render tree standard logging
> in a much nicer way.

In this case, console.log() is more desirable than output(), because the
console.log() statements will show up in the console interleaved with the
XHR requests, so you know if the logging happened during the enabled
or disabled phases. Using output() puts the enabled / disabled / sending XHR
output up top, and there is some logging from the console, but you won't
know when it happened.

> LayoutTests/http/tests/inspector/console-xhr-logging.html:50
>  +      if (WebInspector.monitoringXHREnabled)
> You could do this check earlier and not do waitUntilDone in this branch.
> 
> LayoutTests/http/tests/inspector/console-xhr-logging.html:62
>  +      if (!WebInspector.monitoringXHREnabled)
> Ditto.

Done. I moved the waitUntilDone later, and early return in these if statements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.