[Webkit-unassigned] [Bug 43264] Web Inspector: inspector tests should be frontend-driven

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43264





--- Comment #5 from Pavel Podivilov <podivilov at chromium.org>  2010-08-17 08:07:31 PST ---
(In reply to comment #3)
> (From update of attachment 63088 [details])
> LayoutTests/http/tests/inspector/inspector-test2.js:162
>  +          "if (!InspectorTest) {",
> !window.InspectorTest, otherwise you'll get an exception.
done

> LayoutTests/http/tests/inspector/inspector-test2.js:174
>  +      layoutTestController.evaluateInWebInspector(completeTestCallId, "true");
> This roundtrip shouldn't be needed(at least at the new tests).
done

> LayoutTests/http/tests/inspector/inspector-test2.js:69
>  +  function createKeyEvent(keyIdentifier)
> Let's move all these methods on to InspectorTest object so that it's easy to distinguish test methods from the rest of front-end methods.
This methods are actually private methods of InspectorTest not visible from outside. We can make them public if needed by tests.
> 
> LayoutTests/http/tests/inspector/inspector-test2.js:24
>  +  InspectorTest.push = function(text)
> maybe rename it to addResult?
done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.