[Webkit-unassigned] [Bug 42886] Web Inspector: implement DOM breakpoints

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42886





--- Comment #7 from Pavel Podivilov <podivilov at chromium.org>  2010-08-17 06:55:36 PST ---
(In reply to comment #5)
> (From update of attachment 62416 [details])
> Few nits below. Otherwise, looks very good!
> 
> WebCore/bindings/js/ScriptDebugServer.h:82
>  +      void breakProgram() { }
> Please file a bug against WebKit / JSC and put a FIXME referring the bug here.
Done

> WebCore/inspector/InspectorBackend.idl:109
>  +          void setDOMBreakpoint(in long nodeId, in long type);
> Please rebase, this file no longer exists.
Done

> WebCore/inspector/InspectorDOMAgent.cpp:1027
>  +  #if ENABLE(JAVASCRIPT_DEBUGGER)
> I think you need to optimize this:
> 1) do not enter this code when there are no dom breakpoints
> 2) when setting breakpoint on node, set it on all of its parents instead. that way you spend time on setting breakpoint, not on dom events
Done

> WebCore/inspector/InspectorDOMAgent.cpp:761
>  +  void InspectorDOMAgent::setDOMBreakpoint(long nodeId, long type)
> type should be enum, synchronized with corresponding js enum.
This method is called from generated code, so we can't have enum here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.