[Webkit-unassigned] [Bug 41842] Add feature detection support for NRWT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41842





--- Comment #17 from Gabor Rapcsanyi <rgabor at inf.u-szeged.hu>  2010-08-17 06:02:42 PST ---
(In reply to comment #15)
> (From update of attachment 63993 [details])
> This is nitpicking, but you could add:
> 
>     if not symbol_list:
>         return []
> 
> here just to reduce the indentation levels. On the other hand, when would this ever be null? It looks like the rest of the code works fine even if this list is null, so this check could be an unnecessary (and slightly confusing) optimization.
> 
> 
> > +        directories_for_symbol = self.get_directories_for_symbol()
> > +        skipped_directories = []
> > +        if symbol_list:
> > +            for feature_symbol in directories_for_symbol:
> > +                symbol = [library_symbol for library_symbol in symbol_list if feature_symbol in library_symbol]

This return [] is necessary because it puts all directory to skipped_directories if it doesn't find the symbols. So if the ports doesn't declare _path_to_library() method, all of the directories will be skipped without of this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.