[Webkit-unassigned] [Bug 43963] Avoid increasing required alignment of target type warning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43963





--- Comment #13 from deepak <deepak.m at allaboutif.com>  2010-08-17 02:20:25 PST ---
(In reply to comment #12)
> > JavaScriptCore/pcre/pcre_compile.cpp +2592
> 
> Did you mean this one?
> http://trac.webkit.org/browser/trunk/JavaScriptCore/pcre/pcre_compile.cpp#L2594

Yes but sorry , that was my mistake .. i didn't "StdLibExtras.h"now it is not giving warnings.

> JSRegExp* re = reinterpret_cast_ptr<JSRegExp*>(new char[size]);
> 
> 
> > and in following lines also
> > 
> > WebCore/platform/gtk/ScrollbarGtk.cpp +53
> 
> I am not familiar with Gtk+. What is GTK_ADJUSTMENT ?
> Probably you can use reinterpret_cast_ptr here as well:
> http://trac.webkit.org/browser/trunk/WebCore/platform/gtk/ScrollbarGtk.cpp#L55

check my comment below

> 
> > WebKit/gtk/webkit/webkitwebview.cpp   2972 and 2973
> 
> Could you point those lines in this link:
> http://trac.webkit.org/browser/trunk/WebKit/gtk/webkit/webkitwebview.cpp

http://trac.webkit.org/browser/trunk/WebKit/gtk/webkit/webkitwebview.cpp#L3087
http://trac.webkit.org/browser/trunk/WebKit/gtk/webkit/webkitwebview.cpp#L3088

http://trac.webkit.org/browser/trunk/WebCore/platform/gtk/ScrollbarGtk.cpp#L55

And i replaced them like this (as well as in ScrollbarGtk.cpp#L55)

reinterpret_cast_ptr<GtkAdjustment*>((gtk_adjustment_new(0.0, 0.0, 0.0, 0.0, 0.0, 0.0)));

And all warnings disappeared :)

Now i don see any alignment warnings with all these changes :) (atleast in release build) .. I will enable debug and re compile again.

Thanks Loki, I hope this will help others also ..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.