[Webkit-unassigned] [Bug 44062] [Qt] Use LAZY_NATIVE_CURSOR

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 02:00:40 PDT 2010


--- Comment #5 from Balazs Kelemen <kb at inf.u-szeged.hu>  2010-08-17 02:00:40 PST ---
> WebCore/platform/qt/CursorQt.cpp:73
>  +  #endif
> I guess you need to return 0 after this

Good catch.

> WebCore/platform/qt/CursorQt.cpp:83
>  +          m_platformCursor = new QCursor(Qt::ArrowCursor);
> wouldn't a lookup table be better?

There is not other way of mapping from cursor types to QCursor objects than hard coding it so the best lookup table is a switch :)

> WebCore/platform/qt/CursorQt.cpp:86
>  +          m_platformCursor = new QCursor(Qt::CrossCursor);
> Where are these being deleted?

Right, it should be deleted in the destructor.

> Does the Qt QWidget::setCursor stuff still work after this change? Please test.

I did not see any regressions however I just did a quick browsing with the change. I would use the bots for testing. I will upload a new patch that fixes the problems you find (with the EFL and the spelling thing).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list