[Webkit-unassigned] [Bug 43992] [chromium] scrolling issues when accelerated compositor is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43992


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64544|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from David Levin <levin at chromium.org>  2010-08-16 21:21:00 PST ---
(From update of attachment 64544)
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 163f6c5..cbaecba 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,20 @@
> +2010-08-16  Alexey Marinichev  <amarinichev at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [chromium] scrolling issues when accelerated compositor is enabled
> +        https://bugs.webkit.org/show_bug.cgi?id=43992

It would be nice to have some explanation of why the int cast/floorf call is being removed. (Is that the off-by-half bug?)
> +

Is it possible to create a layout test for this (that verifies the fix when accelerated compositing is on)?


> diff --git a/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp b/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
> +    } else if (abs(scrollDelta.y()) > contentRect.height() || abs(scrollDelta.x()) > contentRect.width())
> +        // Scrolling larger than the contentRect size does not preserve any of the pixels, so there is
> +        // no need to copy framebuffer pixels back into the texture.
> +        m_scrollPosition = scrollPosition;

This should have {} around it since the else clause is more than one logical line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.