[Webkit-unassigned] [Bug 42960] [GStreamer] media/invalid-media-url-crash.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42960


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62549|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2010-08-16 11:00:37 PST ---
(From update of attachment 62549)

>  void StreamingClient::wasBlocked(ResourceHandle*)
>  {
> +    WebKitWebSrcPrivate* priv = m_src->priv;
> +    GST_ERROR_OBJECT(m_src, "Request was blocked");
> +    GST_ELEMENT_ERROR(m_src, RESOURCE, OPEN_READ, ("Access to \"%s\" was blocked", priv->uri), (0));
>  }

>  void StreamingClient::cannotShowURL(ResourceHandle*)
>  {
> +    WebKitWebSrcPrivate* priv = m_src->priv;

Just a minor nit, you can simply use m_src->priv->uri here instead of caching
the pointer locally. LGTM with those lines changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.