[Webkit-unassigned] [Bug 43276] Implements IDBKeyPath extractor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43276





--- Comment #27 from Marcus Bulach <bulach at chromium.org>  2010-08-16 10:27:52 PST ---
(In reply to comment #26)
> forgot r=me

(In reply to comment #25)
> (From update of attachment 64128 [details])
> need change log
> 
> WebCore/bindings/v8/IDBBindingUtilities.cpp:65
>  +          switch (keyPath[i].type) {
> Maybe this would be better if it were an if statement?
> 
> (Just kidding.  :-)
> 
> WebCore/bindings/v8/IDBBindingUtilities.h:33
>  +  #include <wtf/Vector.h>
> You don't need this.
> 
> WebKit/chromium/src/WebIDBKeyPath.cpp:49
>  +      : m_private(new WTF::Vector<IDBKeyPathElement>(elements)),
> comma on next line
> 
> WebKit/chromium/src/WebIDBKeyPath.cpp:41
>  +  {
> Initialize m_parseError?

thanks, Jeremy! all comments addressed, landing it now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.