[Webkit-unassigned] [Bug 43930] Apparent error in FrameLoaderClientQt::createFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43930





--- Comment #3 from Leo Yang <leo.yang at torchmobile.com.cn>  2010-08-16 07:21:14 PST ---
(In reply to comment #2)
> (From update of attachment 64262 [details])
> How come this having been breaking anything?

Some logic in loadURLIntoChildFrame is unreachable. We can't run into the following if statement. And if we add some operations which are related with parent frame in loadURLIntoChildFrame in the future, it's buggy for qt porting.

 917     if (parentItem && parentItem->children().size() && isBackForwardLoadType(loadType)) {
 918         HistoryItem* childItem = parentItem->childItemWithTarget(childFrame->tree()->name());
 919         if (childItem) {
 920             // Use the original URL to ensure we get all the side-effects, such as
 921             // onLoad handlers, of any redirects that happened. An example of where
 922             // this is needed is Radar 3213556.
 923             workingURL = KURL(ParsedURLString, childItem->originalURLString());
 924             childLoadType = loadType;
 925             childFrame->loader()->history()->setProvisionalItem(childItem);
 926         }
 927     }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.