[Webkit-unassigned] [Bug 43974] Geolocation requests in progress when the frame is disconnected should invoke the error callback

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43974


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64481|review?                     |review+
               Flag|                            |




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2010-08-16 03:41:22 PST ---
(From update of attachment 64481)
> Instead, we should attempt to invoke the error callback for all ongoing requests.

I think that this is a good change because it matches XMLHttpRequest (which dispatches an abort event when window is closed). But for posterity, it would be best to document why else we want this. Does any spec say so?

+    if (m_fatalError)
+        return;

It might be helpful to add a comment explaining why the first error wins.

r=me. The split js-test makes me sad.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.