[Webkit-unassigned] [Bug 43960] [Chromium] styled scroll bar on the window is painted badly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43960





--- Comment #4 from MORITA Hajime <morrita at google.com>  2010-08-15 22:06:41 PST ---
Hi Dimitri, thank you for reviewing!
I updated the patch.

> WebCore/ChangeLog:15
>  +          (WebCore::RenderObject::hasBackground):
> Please use this template to outline the changes you made. For instance: "Moved most of this logic to blah".
OK, added some explanation. Thank you for pointing this out.

> 
> WebCore/rendering/RenderScrollbar.cpp:144
>  +  void RenderScrollbar::adjustStyle(RenderStyle* style) const
> Why a separate method for this? It's only being used in one place and it's short enough to inline, I think?
> 
Agreed and inlined.

> WebCore/rendering/RenderScrollbar.cpp:149
>  +      // causes visual artifact like non-repainted durty region.
> "painted" and "dirty".
Oops. Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.