[Webkit-unassigned] [Bug 40377] [Qt] When Qt graphicslayer gets a setNeedsDisplay (ie all) it shouldn't record the rect then

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40377





--- Comment #14 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-08-14 07:38:17 PST ---
(From update of attachment 59440)
WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:170
 +      QPixmap recache(bool);
In the WebKit project we are trying to move away from using bools as arguments where it is not obvious what they mean. recache(false) does that mean to not recache? probably not. Use an enum instead.

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:348
 +      // Nothing to render
Add dot at end of comment.

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:343
 +      m_pendingContent.updateAll = false;
All what? all regions? everything?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.