[Webkit-unassigned] [Bug 43996] Add ability to count text matches without marking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43996


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64387|review?                     |review-
               Flag|                            |




--- Comment #2 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-08-13 17:13:10 PST ---
(From update of attachment 64387)
WebCore/page/Frame.cpp:1257
 +  unsigned Frame::markAllMatchesForText(const String& target, bool caseFlag, unsigned limit)

This method should be removed.  Since WebKit is the only caller, it should switch to using countMatchesForText() and pass in true for markMatches.  The WebCore.exp.in file will need to be updated to remove WebCore::Frame::markAllMatchesForText() and to add WebCore::Frame::countMatchesForText().


WebCore/page/Frame.h:211
 +          unsigned markAllMatchesForText(const String&, bool caseFlag, unsigned limit);

This declaration can be removed.


WebKit/mac/WebView/WebHTMLView.mm:6206
 +  - (NSUInteger)countMatchesForText:(NSString *)string caseSensitive:(BOOL)caseFlag limit:(NSUInteger)limit markMatches:(BOOL)markMatches

This method should call WebCore::Frame::countMatchesForText() instead of WebCore::Frame::markAllMatchesForText() if it uses it.


WebKit/mac/WebView/WebPDFView.mm:633
 +  - (NSUInteger)countMatchesForText:(NSString *)string caseSensitive:(BOOL)caseFlag limit:(NSUInteger)limit markMatches:(BOOL)markMatches

This method should call WebCore::Frame::countMatchesForText() instead of WebCore::Frame::markAllMatchesForText() if it uses it.


WebKit/mac/WebView/WebView.mm:4368
 +  - (NSUInteger)countMatchesForText:(NSString *)string caseSensitive:(BOOL)caseFlag highlight:(BOOL)highlight limit:(NSUInteger)limit markMatches:(BOOL)markMatches

This method should call WebCore::Frame::countMatchesForText() instead of WebCore::Frame::markAllMatchesForText() if it uses it.


r- to address the above issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.