[Webkit-unassigned] [Bug 43658] Calling window.print() before the page is loaded results in a blank printed page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43658


Lei Zhang <thestig at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63791|0                           |1
        is obsolete|                            |
  Attachment #63966|0                           |1
        is obsolete|                            |
  Attachment #63966|review?                     |
               Flag|                            |
  Attachment #64371|                            |review?
               Flag|                            |




--- Comment #12 from Lei Zhang <thestig at chromium.org>  2010-08-13 13:48:24 PST ---
Created an attachment (id=64371)
 --> (https://bugs.webkit.org/attachment.cgi?id=64371)
Defer printing patch 3 - add a manual test.

(In reply to comment #11)
> (From update of attachment 63966 [details])
> Oops. Sorry for the latency. I think the test method I've added cannot help testing window.print(). I think we can add WebCore/manual-tests for this test.

Ok, I added a copy of 25027.htm to manual-tests. See try 4.

> This change looks good to me as the new behavior sounds more compatible to other browsers. I hesitate to r+ this change now because this patch is related to loader which I don't know well.
> 
> WebCore/loader/FrameLoader.cpp:2233
>  +          window->print();
> A question: don't we need to reset m_printDeferred?

DOMWindow::print() resets m_printDeferred.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.