[Webkit-unassigned] [Bug 37630] delete redundant test outputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37630





--- Comment #30 from Dirk Pranke <dpranke at chromium.org>  2010-08-13 13:21:34 PST ---
(In reply to comment #29)
> detect_scm_system knows how to crawl up until it finds the root.
> 
> I think you want something like this:
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/tool/main.py#L80
> 
> Which is why that code should be shared on some object other than WebKitPatch's main class.

Well, sort of.

That code finds the root given $CWD, which is appropriate in some cases. The code in port.base finds the root given the path to port/base.py, which means that it'll work even if you're not actually in the tree; it uses the root of the tree containing the code you're running.

I'm not sure if that would be appropriate for scm-related stuff, but it seems fine for test-related stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.