[Webkit-unassigned] [Bug 43962] Improve FEGaussianBlur algorithm performance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43962





--- Comment #4 from Alejandro G. Castro <alex at igalia.com>  2010-08-13 09:59:13 PST ---
(In reply to comment #3)
> (From update of attachment 64318 [details])
> This looks good! :)
> 
> >  #include "GraphicsContext.h"
> >  #include "ImageData.h"
> >  #include <wtf/MathExtras.h>
> 
> Needs the Sencha copyright (see also Patch 2 in https://bugs.webkit.org/show_bug.cgi?id=34479).
> 

Oh, sorry, I'll do it.

> > +#define CURRENT_ALGO 0
> 
> Have you profiled the different between using CURRENT_ALGO and not using it?
> 

Not yet, but I'll do it :)

> > +    tmpImageBuffer->context()->setFillPattern(pattern.get());
> > +    tmpImageBuffer->context()->fillRect(imageRect);
> 
> This works only if every platform graphics stack supports fast 90 degree rotation (aka transposed). Qt supports this hence why I use it.
> Otherwise, it is faster to transpose the pixels ourselves.
> 
> Possible idea: provide a default ImageBuffer::transpose and let the platform overrides it if it has a faster version.
> 

Uhu, not sure what cairo is doing, I'm going to profile and we can check if it is a problem.

> BTW, track also Hyatt's refactoring on Canvas. This might or might not conflict with some of his changes, but just in case. https://bugs.webkit.org/show_bug.cgi?id=43507

Yep, probably we will sabe the two image copies.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.