[Webkit-unassigned] [Bug 39164] [CMake] Cleanup generator code and port it to windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39164





--- Comment #15 from Leandro Pereira <leandro at profusion.mobi>  2010-08-13 09:48:34 PST ---
(In reply to comment #11)
> (From update of attachment 63151 [details])
> Let's retry, EFL should work, according to paroga.

Strangely enough, the other time the same patch was added to SVN, WebCore's CMakeLists.txt didn't get updated to reflect the changes. It seems to be fine now, but while trying to build with this patch, I get the following message (clean SVN tree):

CMake Error at cmake/WebKitGenerators.cmake:137 (FIND_PACKAGE_HANDLE_STANDARD_ARGS):
  Unknown CMake command "FIND_PACKAGE_HANDLE_STANDARD_ARGS".
Call Stack (most recent call first):
  CMakeLists.txt:15 (INCLUDE)

I'm on CMake 2.8.2, so I don't think this is standard. I was able to find a file that defines this macro, and the build now seems to work after I include it. The file does not, however, mention its license, so I cannot upload it to the WebKit repo.

Patrick, could you please send another patch adding the definition of this macro?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.