[Webkit-unassigned] [Bug 43960] [Chromium] styled scroll bar on the window is painted badly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43960





--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2010-08-13 09:33:18 PST ---
(From update of attachment 64317)
I am not sure if this is a good patch (not yet that knowledgeable about the mechanics here :), but here are a few nits:

WebCore/ChangeLog:15
 +          (WebCore::RenderObject::hasBackground):
Please use this template to outline the changes you made. For instance: "Moved most of this logic to blah".

WebCore/rendering/RenderScrollbar.cpp:144
 +  void RenderScrollbar::adjustStyle(RenderStyle* style) const
Why a separate method for this? It's only being used in one place and it's short enough to inline, I think?

WebCore/rendering/RenderScrollbar.cpp:149
 +      // causes visual artifact like non-repainted durty region.
"painted" and "dirty".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.