[Webkit-unassigned] [Bug 42976] Implement IDBKeyPath parser.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42976





--- Comment #32 from Marcus Bulach <bulach at chromium.org>  2010-08-13 08:16:12 PST ---
thanks for the quick reply chris! comments addressed, more inline:

(In reply to comment #28)
> Looks like a lot of care has been taken; thanks.
> What about:
> +    int number = numberAsString.toIntStrict(&ok);
> 
> Does toIntStrict() permit negatives? If so, is that desired and should it be rejected?

good point! made it unsigned, and using toUIntStrict.

> 
> What about a crazy large int? Should that be rejected out of hand here or does that check belong at a different level?
added a test for it (toUIntStrict fails for larger-than-int). also, you're correct: higher level (https://bugs.webkit.org/show_bug.cgi?id=43276) tests for the value being available in the array, it never de-references as-is.

another quick look please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.