[Webkit-unassigned] [Bug 43779] RenderImage::imageChanged invalidates wrong area

Fri Aug 13 00:20:44 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43779

--- Comment #38 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-13 00:20:44 PST ---
(In reply to comment #37)
> (In reply to comment #36)
> > (From update of attachment 64272 [details] [details])
> > Interessting, didn't think about the possibility to remove RenderImageGeneratedContent, with that removal your two new RenderImageResources classes make a lot more sense.
> :-)
> 
> > The problem is that you're still storing the CachedResourceHandle<CachedImage> for RenderImageResourceStyleImage through inheritance, which wastes memory, as it's unused.
> I'm not sure if it's realy unused: RenderImageResourceStyleImage will call setCachedImage only if StyleImage::isCachedImage() is true. Otherwise the default CachedImage will be used.
> I don't know the code exactly to say if that's correct. I only moved it from RenderImageGeneratedContent. ;-)

Hah, that's just true, I overlooked that fact, so it's fine as is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.