[Webkit-unassigned] [Bug 43779] RenderImage::imageChanged invalidates wrong area

Thu Aug 12 23:58:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43779

Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64272|review?                     |review-
               Flag|                            |

--- Comment #36 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-12 23:58:14 PST ---
(From update of attachment 64272)
Interessting, didn't think about the possibility to remove RenderImageGeneratedContent, with that removal your two new RenderImageResources classes make a lot more sense.
Though I still have a suggestion. I'd love to have an abstract RenderImageResource (renamed to RenderImageSource) class, and two other classes inheriting from it.

RenderImageSource (contains pure-virtual image/errorOccurred, etc.. functions)
RenderCachedImageSource (inherits from RenderImageSource)
RenderStyleImageSource (ditto)

The problem is that you're still storing the CachedResourceHandle<CachedImage> for RenderImageResourceStyleImage through inheritance, which wastes memory, as it's unused.
Your approach is fine in general, I'm just asking for one more class, to save memory, and some renames.

Do you agree with the idea?
I have another idea to avoid the toRenderFoo(renderer())->imageResource() dance, and would like to discuss that on IRC.

P.S. ClipboardGtk has problems, see gtk build output.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.