[Webkit-unassigned] [Bug 43902] flaky websocket/tests/frame-length-overflow.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43902





--- Comment #9 from Fumitoshi Ukai <ukai at chromium.org>  2010-08-12 23:55:19 PST ---
(In reply to comment #8)
> +    , m_readShutdowned(false)
> 
> Shutdown is not a verb, so this should be "m_readShutDown" for better grammar. 
> 
> > It means the channel won't receive any more data, like SHUT_RD.
> 
> This sounds like something we should be asking the channel about then, not something to keep in WebSocket object. If it's better to keep this in WebSocket, then the name needs to be different yet, indicating what it means from this code point of view.

Hmm, how about m_readClosed, or m_shouldDiscardReceivedData ?

> > Yes. and make sure it doesn't read the same buffer again.
> 
> Doesn't setting m_errorClosed/m_readShutdowned already prevent that?

Ah, yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.