[Webkit-unassigned] [Bug 43899] Add test_expectations.txt syntax checker to check-webkit-style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 23:46:02 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #64305|review?                     |review+
               Flag|                            |

--- Comment #8 from Shinichiro Hamaji <hamaji at chromium.org>  2010-08-12 23:46:01 PST ---
(From update of attachment 64305)
Looks great. A few nitpicks:

 +          # Suppress error messages since they will be reported later.
Suppress error messages of test_expectations module since...

would be clearer

 +  try:
It would be better to add a comment why we want these lines

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list