[Webkit-unassigned] [Bug 37630] delete redundant test outputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37630





--- Comment #28 from Dirk Pranke <dpranke at chromium.org>  2010-08-12 20:08:09 PST ---
(In reply to comment #27)
> scm.py knows how to handle running in those cases.  Perhaps this should use more of webkitpy code to take care of that for you.
> 
> You can use detect_scm_system to find the checkout_root.
> 
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/checkout/scm.py#L41
> 
> We've long talked about making it easier to write non-webkit-patch tools which use webkitpy.  We just have a couple bugs to fix to make that possible.  (Mostly abstracting the data storage out of WebKitPatch into a separate Tool class that can be set as self.tool on Command instances instead of WebKitPatch.)

detect_scm_system() takes a path as input, which doesn't help if you don't know what path you
want to use. 

It would be nice if it had a way to bootstrap itself better, like we do in webkitpy/layout_tests/port/base.py:

        if not self._webkit_base_dir:
            abspath = os.path.abspath(__file__)
            self._webkit_base_dir = abspath[0:abspath.find('WebKitTools')]
            _log.debug("Using WebKit root: %s" % self._webkit_base_dir)

You could do something like this if path was None.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.