[Webkit-unassigned] [Bug 43512] [GTK] Use GSettings to save/restore Web Inspector settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43512


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64224|review?                     |review+
               Flag|                            |




--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2010-08-12 08:02:31 PST ---
(From update of attachment 64224)
> +#if HAVE_GSETTINGS
> +template <> GVariant* refGPtr(GVariant* ptr)
> +{
> +    if (ptr)
> +        g_variant_ref(ptr);
> +    return ptr;
> +}
> +
> +template <> void derefGPtr(GVariant* ptr)
> +{
> +    g_variant_unref(ptr);
> +}
> +#endif
> +#if HAVE_GSETTINGS
> +template <> GVariant* refGPtr(GVariant* ptr);
> +template <> void derefGPtr(GVariant* ptr);
> +#endif

I'd rather this be unprotected by HAVE_GSETTINGS. It might be useful later
for non-GSettings code!

> +    while (*iter != NULL) {
> +        if (g_str_equal(schemaID, *iter))
> +            return true;
> +        iter++;
> +    }

Style error, as the bot mentioned.

But if you change those two small nits and remove the inadvertant change to the GIR
file, r=me. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.