[Webkit-unassigned] [Bug 43848] Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43848





--- Comment #9 from Dean Jackson <dino at apple.com>  2010-08-12 07:38:16 PST ---
Pages are created in a number of places (SVGImage, as you show in your patch). They don't always need all the clients (eg. you don't need the inspector client in SVGImage), so there are already cases where null clients are passed in.

This gets even more common in the platform implementations. 

It's a good question as to whether it is better to protect against null clients or to create Empty/Stub versions and use them all over the place.

By the way, I'm currently struggling to work out why DeviceOrientation is a client of Page anyway. It seems to me that it would make more sense on Frame, where it could be easily suspended when the user navigates back/forward, or other similar situations. Without this, I get into the case where a Page is still trying to dispatch events even though the document/window have gone away.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.