[Webkit-unassigned] [Bug 43276] Implements IDBKeyPath extractor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43276


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64128|                            |review+
               Flag|                            |




--- Comment #25 from Jeremy Orlow <jorlow at chromium.org>  2010-08-12 04:51:48 PST ---
(From update of attachment 64128)
need change log

WebCore/bindings/v8/IDBBindingUtilities.cpp:65
 +          switch (keyPath[i].type) {
Maybe this would be better if it were an if statement?

(Just kidding.  :-)

WebCore/bindings/v8/IDBBindingUtilities.h:33
 +  #include <wtf/Vector.h>
You don't need this.

WebKit/chromium/src/WebIDBKeyPath.cpp:49
 +      : m_private(new WTF::Vector<IDBKeyPathElement>(elements)),
comma on next line

WebKit/chromium/src/WebIDBKeyPath.cpp:41
 +  {
Initialize m_parseError?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.