[Webkit-unassigned] [Bug 40418] Removes duplication between platform/chromium-win and platform/chromium-mac test expectations by moving files to platform/chromium.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 02:51:32 PDT 2010


--- Comment #12 from Marcus Bulach <bulach at chromium.org>  2010-08-12 02:51:32 PST ---
the python script mentioned here was submitted as part of:

eric: I'm happy to re-construct this patch using the new script, but given the timezone difference (I'm on GMT), I guess it'd be more effective if you could run the script / review / land in PST? since it's going to be a reasonably broad change, I'm afraid the patch will get stale and we'll have to resolve things if I try to do from this side of the pond.. thoughts?

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > (In reply to comment #7)
> > > > It should be possible to write a generic version of this script using the classes in webkittools/scripts/webkitpy/layout_test/port /  a generic version of this script 
> > > > would be HUGELY useful!
> > > 
> > > I'm happy to port it over to python, but do you think it's actually going to be used more than once? :) I'm always a bit worried about one-off scripts that get rotten too quickly.
> > > 
> > > (oh, and just checking: if I do port to python, I should use things like python's md5 rather than depend on external tools such as fdupes, right?)
> > 
> > We have a bunch of one-off scripts which we have committed to WebKitTools/Scripts and run occasionally.  Most of them are perl, but more and more of our new scripting is moving to python.
> cool! I'll take a look  at webkitpy and will rewrite this script using those classes.
> > 
> > I guess I didn't realize this wasn't already python.  It certainly looks like it. :)
> hehe :) yeah, it's python, except the first line which uses "fdupes".. it's trivial to rewrite in python though, only takes probably four lines instead of one.. :)
> > 
> > I think what you've done is great.  I just would love a script that we can run every 6 months to make sure we don't have duplicate layout test results.  Layout tests are constantly changing, and as the port converge and diverge in their behavior we should be able to easily keep the duplicate result files to a minimum.
> sounds a good reason to check it in!
> I'm not too familiar with the "checkstyle", but do you think we could add such checks (roughly as a pre-submit) in there?
> if that's not abusing the checkstyle :) we'd have an early warning for duplication..
> > 
> > An advanced version of such a script could point out that all the ports agree with each other, just that the main expected results should really be mac-only, or some-such.  That's probably a v2 feature though. :)
> ok, let me start drafting and will send you a patch shortly. thanks!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list