[Webkit-unassigned] [Bug 43779] RenderImage::imageChanged invalidates wrong area

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43779


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64163|review?                     |review-
               Flag|                            |




--- Comment #16 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-12 00:03:26 PST ---
(From update of attachment 64163)
Also some comments:
WebCore/rendering/RenderSVGImage.cpp:51
 +      m_cachedImage = RenderImageResource::create(this);
Can be moved in the initialization list.

WebCore/rendering/RenderSVGImage.cpp:56
 +      m_cachedImage.clear();
Not needed IIRC.

WebCore/rendering/RenderSVGImage.cpp:104
 +                  if (svgStyle->shapeRendering() == SR_CRISPEDGES)
Is that necessary for images? I don't think so.

WebCore/rendering/RenderSVGImage.cpp:169
 +      // This empty image may be cached by SVG filter effects which must be invalidated.
That change is not correct, you basically reverted to an older version of the imageChanged version.
The SVGResourcesCache::... call is correct.

WebCore/svg/SVGImageElement.cpp:174
 +      if (RenderSVGImage* imageObj = toRenderSVGImage(renderer())) {
Change to early return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.