[Webkit-unassigned] [Bug 43864] Canvas2D does not support images larger than system's GPU max texture size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 23:00:10 PDT 2010


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #64177|review?                     |review-
               Flag|                            |

--- Comment #8 from David Levin <levin at chromium.org>  2010-08-11 23:00:10 PST ---
(From update of attachment 64177)
r- based on James' feedback alone.

Please make sure to add spaces around operators. For example, "2*m_borderTexels" is done in a few places and there are many places where there aren't spaces around +, -, *.

If the clause of an if (or else) statement spans more than one physical line it needs braces around it. Here's one such example:
154         if (swizzle)
 155             uploadBuff = copySubRect<true>(
 156             pixels32, tileBoundsWithBorder.x(), tileBoundsWithBorder.y(),
 157             tempBuff, tileBoundsWithBorder.width(), tileBoundsWithBorder.height(), m_tiles.totalSizeX());

There are others.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list