[Webkit-unassigned] [Bug 42042] An empty value for xml:lang isn't considered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42042





--- Comment #11 from Rob Buis <rwlbuis at gmail.com>  2010-08-11 12:28:57 PST ---
Hi,

(In reply to comment #10)
> Yes, <http://trac.webkit.org/changeset/63560>.
> 
> Rob, could you find out an answer to the question in comment 7?

Right, sorry, did not get to it before my summer vacation.

Now that I look at it again, the change may not have been needed indeed, I mean the last
isEmpty -> isNull change in my patch.

Basically empty values (as well as null values) can never match the :lang selector, since at
least the way we parse it it can't be empty, i.e. length > 0, so the original way to break early there
seems fine to me. The only reason why that part of the patch worked, is that empty values will fail
on the next if statement and so a break will be done as before, just (unneededly so) a bit later.

I'll create a correcting patch soon.
Cheers,

Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.