[Webkit-unassigned] [Bug 43359] [Qt] Fix warnings: unknown conversion type character 'l' in format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43359


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64132|                            |review?
               Flag|                            |




--- Comment #2 from Csaba Osztrogonac <ossy at webkit.org>  2010-08-11 10:13:38 PST ---
Created an attachment (id=64132)
 --> (https://bugs.webkit.org/attachment.cgi?id=64132)
proposed fix #2

Fix this warning:
..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: unknown conversion type character 'l' in format
..\..\..\WebCore\loader\FTPDirectoryParser.cpp:191:47: warning: too many arguments for format

I prefer PRI and SCN macros defined in inttypes.h, but 
I can't find any occurance of them in WebKit trunk.
Accordingly I propose a fix similar to String::number(...).

JavaScriptCore/wtf/text/WTFString.cpp:
...
String String::number(long long n)
{
#if OS(WINDOWS) && !PLATFORM(QT)
    return String::format("%I64i", n);
#else
    return String::format("%lli", n);
#endif
}
...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.