[Webkit-unassigned] [Bug 37630] delete redundant test outputs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 09:43:06 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37630


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64040|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #22 from Eric Seidel <eric at webkit.org>  2010-08-11 09:43:05 PST ---
(From update of attachment 64040)
WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:53
 +          back on.  All platforms fall back on 'base'.
Seems part of this comment belongs next to _BASE_PLATFORM, but ok.

WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:68
 +  def parse_git_output(git_output, glob_pattern):
I would have named this parse_git_ls_tree_output

Looks great though.  Thanks for taking this on.

We probably should have done more of this as a class, rather than free functions.  Eventually it will probably get moved deeper into webkitpy.  But I think this is a good starting point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list