[Webkit-unassigned] [Bug 43276] Implements IDBKeyPath extractor.

Wed Aug 11 06:23:22 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43276

--- Comment #20 from Marcus Bulach <bulach at chromium.org>  2010-08-11 06:23:22 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > There is a subtle point to not defining reset() inline. If it is inline, then T must be defined when WebPrivatePtr<T> is instantiated, because it will try to bind the "delete m_ptr" call. If reset() is not inline, it's enough to have T forward-declared when instantiating the template, which is a good thing. OwnPtr does this too, for the same reason AFAIK.
> 
> I hadn't thought this through. Obviously it has to be inline, because it's in a template. I'm not sure what deleteOwnedPtr() in OwnPtrCommon.h does, but it looks tricky. Please disregard my comment.

you're right, and the WEBKIT_API / IMPLEMENTATION and the templates are making me dizzy :)
I think we need to define the destructor inline and make it call "reset()", which will be declared as an API method, but defined inline under an IMPLEMENTATION guard. it must also COMPILE_ASSERT it knows sizeof(T). I'll address Jeremey's previous comment and try to get this one, will send a new patch shortly..

oh, and I'm happy to split and put in the separate bug as well, but I'd prefer to do that once we figure out the right usage here. how does it sound?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.