[Webkit-unassigned] [Bug 40328] GtkLauncher fails to build: Undefined references to openFile, readFromFile, and seekFile

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40328


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58536|review?                     |review-
               Flag|                            |




--- Comment #9 from Gustavo Noronha (kov) <gns at gnome.org>  2010-08-11 05:28:26 PST ---
(From update of attachment 58536)
 304 // Since above methods are implemented without GLib calls and variables,
 305 // just use code from WebCore/platform/posix/FileSystemPOSIX.cpp

Will these work on Windows? Why not use the glib tools that enable portability here? Also, yes, I think you can just remove the test from the skipped list =)

I'll r- given krit's comments and my own.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.