[Webkit-unassigned] [Bug 43810] New: Commit-queue shouldn't land patch if cq+ was removed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 10 14:41:33 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=43810
Summary: Commit-queue shouldn't land patch if cq+ was removed
Product: WebKit
Version: 528+ (Nightly build)
Platform: All
OS/Version: All
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: ossy at webkit.org
CC: eric at webkit.org, abarth at webkit.org, abecsi at webkit.org
If you set cq+ for a patch, commit queue script will add it to the commit queue.
But if you realise later that you shouldn't have set cq+ and then you remove it
(or set cq-), the script will land the patch irrespectively of the new cq flag.
I think cq ignores modified flag only after it started landing.
Otherwise it removes the patch from the queue correctly.
I propose commit queue should check cq flag again after build&test
finished and before landing to avoid this unwanted commit.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list