[Webkit-unassigned] [Bug 43742] Fast-path for array lookup with double subscript

Mon Aug 9 13:22:52 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43742

Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63921|review?                     |review-
               Flag|                            |

--- Comment #2 from Oliver Hunt <oliver at apple.com>  2010-08-09 13:22:52 PST ---
(From update of attachment 63921)
This is incorrect. 1.5 is a valid property, eg.
a=[];
a[1.5] = "Foo"

a["1.5"] === "Foo"; // true
a[1] === undefined; // true

Your patch results in a look up of 1.5 converting to a lookup of 1, which is incorrect.  It's somewhat worrying that this passes tests :-(

Is the double that's being looked up actually an integral value?

--Oliver

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.