[Webkit-unassigned] [Bug 43688] [Qt] Enable JIT on WinCE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43688





--- Comment #10 from Patrick R. Gansterer <paroga at paroga.com>  2010-08-09 03:15:04 PST ---
(In reply to comment #9)
> Created an attachment (id=63878)
 --> (https://bugs.webkit.org/attachment.cgi?id=63878) [details]
> Add GeneratedJITStubs_MSVC.asm to the build system for Windows CE
> 
> Try two.
Clear r-:
1) Missing ChangeLog for Platform.h
2) Wrong place for ENABLE_JIT (don't use OS(WINDOWS); JIT is only supported for ARM now)
3) Set a #define only when when not already set (#ifndef). It must be possible to turn it off by a preprocessordefine.
4) There is already an #define ENABLE_JIT 1 in line 940 at Platform.h

IMHO setting ENABLE_JIT should be done in the pro-file (no changes to the Platform.h) and only form ARM platform.
Add the asm file only for ARM in the pro-file, because WinCE also supports X86, MIPS, SH1.

PS: Please use svn-create-patch. It adds addional info.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.