[Webkit-unassigned] [Bug 41614] RegExp constructor should throw a SyntaxError if invalid flags are specified

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41614





--- Comment #8 from Zoltan Herczeg <zherczeg at webkit.org>  2010-08-09 01:56:50 PST ---
> Could you be more specific?

As I am not a reviewer, it means not much, but:

1) I think a pure global regExpFlagsFromString is unnecessary, we could at least move to this function as a static member function of RegExp (or a static inline function in the .cpp file).

2) As Oliver mentioned, I don't see the reason why two constructor is needed. An "if" in the first constructor would probably be enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.