[Webkit-unassigned] [Bug 42827] Use the js-execute-active(entered) Frame to check the user gesture of page instead of checking the top frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42827





--- Comment #33 from Johnny Ding <jnd at chromium.org>  2010-08-07 21:57:48 PST ---
(In reply to comment #32)
> (From update of attachment 63525 [details])
> Rejecting patch 63525 from commit-queue.
> 
> Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 2
> Last 500 characters of output:
> file LayoutTests/fast/events/popup-blocked-from-iframe-script-expected.txt
> patching file LayoutTests/fast/events/popup-blocked-from-iframe-script.html
> patch unexpectedly ends in middle of line
> patch: **** malformed patch at line 32:  
> 
> fatal: pathspec 'LayoutTests/fast/events/popup-blocked-from-iframe-script.html' did not match any files
> Failed to git add LayoutTests/fast/events/popup-blocked-from-iframe-script.html. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 427.
> 
> Full output: http://queues.webkit.org/results/3636412

Hi Adam, Eric
I am not sure the reason of the commit failure, is that because I missed a new line at the end of 'LayoutTests/fast/events/popup-blocked-from-iframe-script.html'?
The patch was generated by svn-create-patch, I didn't see any error/warning info at that time,.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.