[Webkit-unassigned] [Bug 43531] Web Inspector: Support appcache status change for Chrome

Sat Aug 7 03:10:58 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43531

Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63647|review?                     |review-
               Flag|                            |

--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2010-08-07 03:10:58 PST ---
(From update of attachment 63647)
WebKit/chromium/src/ApplicationCacheHost.cpp:209
 +          if (page && page->inspectorController()->inspectorFrontend() && page->mainFrame() == m_documentLoader->frame())
You should not make ApplicationCacheHost too much involved into the InspectorController's business. inspectorFrontend() should not be used as indication of the frontend availability + it will actually go away this week. You should notify inspector controller on any change and let it decide when to trigger the action.

WebKit/chromium/src/ApplicationCacheHost.cpp:210
 +              page->inspectorController()->applicationCacheAgent()->updateApplicationCacheStatus(status());
So you will simply check applicationCacheAgent for being 0, and if not, notify it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.