[Webkit-unassigned] [Bug 43618] Generalize SVGPathParser to allow more than just strings as input source

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43618


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63806|review?                     |review+
               Flag|                            |




--- Comment #11 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-06 23:12:11 PST ---
(From update of attachment 63806)
r=me, some minor nitpicks before you land:

WebCore/ChangeLog:12
 +          Moved the SVGPathSegType enumeration from SVGPathSeg class for a common use across
Moved the SVGPathSegType enum from SVGPathSeg class in WebCore namespace, for easier access throughout the SVG code.

WebCore/ChangeLog:15
 +          No new tests added.
Doesn't affect any tests, sounds better, creates less worries :-)

WebCore/svg/SVGPathParser.cpp:320
 +      ASSERT(m_source);
Also add ASSERT(m_consumer) here.

WebCore/svg/SVGPathParser.h:44
 +      void setCurrentSource(SVGPathSource* source) { m_source = source;}
Space should be added before ned brace.

WebCore/svg/SVGPathStringSource.cpp:131
 +      if ((*m_current == '+' || *m_current == '-' || *m_current == '.' || *m_current >= '0' && *m_current <= '9')

Ah,  I misread before, didn't see there was another statement on the next line. Please readd the braces around *m_current >= '0' ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.