[Webkit-unassigned] [Bug 41596] Pattern fill with image not rendered after reload

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 23:06:37 PDT 2010


--- Comment #7 from Nikolas Zimmermann <zimmermann at kde.org>  2010-08-06 23:06:37 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > The pattern is rendered into an ImageBuffer in RenderSVGResourcePattern::createTileImage(), by calling SVGRenderSupport::renderSubtreeToImage() with the RenderSVGImage. If this happens too early, there's no image yet, but there's also nothing to update the pattern once the image finally loads.
> There is, RenderSVGImage::imageChanged, contains following code to handle it:
>     // The image resource defaults to nullImage until the resource arrives.
>     // This empty image may be cached by SVG resources which must be invalidated.
>     if (SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(this))
>         resources->invalidateClient(this);
> Not sure what is happening, will check the testcase soon.

Ah I see, how stupid. The code above looks up resources defined on the _image_ itself.
eg. <image clip-path="..." and would notify the clip-path, that it has to recalculate. But if the <image> itself lives in a resources, that one is not updated. should be an easy fix.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list