[Webkit-unassigned] [Bug 43507] Turn ImageBuffer::image/ImageBuffer::imageForRendering to ImageBuffer::image/ImageBuffer::copiedImage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43507





--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2010-08-06 16:50:48 PST ---
I've posted a work-in-progress patch. I'd really appreciate it if someone could take a quick look at it before I get much further. This patch essentially splits ::image() into ::image() (shallow copy) and ::copiedImage (deep copy). For the CG port these seem to be equivalent, as CGBitmapContextCreateImage has copy-on-write behavior (according to http://developer.apple.com/mac/library/documentation/GraphicsImaging/Reference/CGBitmapContext/Reference/reference.html#//apple_ref/c/func/CGBitmapContextCreateImage ). I've also implemented the necessary logic for Skia, Qt and Cairo (though I can only test Cairo currently).

Since ImageBuffer no longer caches the image, the calls need to worry more about reference counting. ::image() and ::copiedImage return PassRefPtr's now, which spidered up the call chain unfortunately. Perhaps there is a better solution there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.