[Webkit-unassigned] [Bug 43618] Generalize SVGPathParser to allow more than just strings as input source

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43618





--- Comment #9 from Dirk Schulze <krit at webkit.org>  2010-08-06 15:19:59 PST ---
(In reply to comment #3)
> (From update of attachment 63719 [details])
> Looks like you're almost there, a small design problem remains:
> 
> The SVGPathSource passed to parsePathDataFromSource, is stored in an OwnPtr in SVGPathParser. As SVGPathParser is a static object in SVGPathParserFactory, no one will delete the SVGPathSource.
> How about changing the design a little, by storing a SVGPathSource* pointer in SVGPathParser, just like it's done for SVGPathConsumer, plus a new setCurrentSource(SVGPathSource*) method.
> 
done.

> 
> This way it's guaranteed that source is going to die, after the build* methods are finished.
> 
> Some const issues:
> WebCore/svg/SVGPathSource.h:32
>  +      virtual bool hasMoreData() = 0;
> This should be const.
done.

> 
> WebCore/svg/SVGPathSource.h:35
>  +      virtual bool moveToNextToken() = 0;
> Ditto.
moveToNextToken is base uppon skipOptionalSpaces, can't const it.

> 
> WebCore/svg/SVGPathSource.h:36
>  +      virtual SVGPathSegType parseSVGSegmentType() = 0;
> for consistency, it should be:
> virtual bool parseSVGSegmentType(SVGPathSegType& result) = 0;
done

> 
> WebCore/svg/SVGPathSource.h:37
>  +      virtual SVGPathSegType nextCommand(SVGPathSegType) = 0;
> maybe write 'previousCommand' as parameter name?
done

> 
> WebCore/svg/SVGPathStringSource.cpp:111
>  +      if ((*m_current == '+' || *m_current == '-' || *m_current == '.' || (*m_current >= '0' && *m_current <= '9'))
> Useless outer brace.
done

Builds on Mac for me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.